The gym bag that doubles as a weekend bag is one of those purchases that sounds like a compromise but actually solves two problems at once. The key is finding a bag that fits in a gym locker without wasted space, has some version of shoe or wet/dry separation, and does not announce itself as exclusively a gym bag when you bring it to a hotel. A 30 to 40 liter duffel is the sweet spot for most people.
Three things: a separate shoe or wet-gear compartment, a locker-friendly size (most gym lockers are about 12 inches wide and 18 inches tall), and materials that do not hold odors. Nylon and polyester are better than canvas for odor resistance — they dry faster and the weave is tighter. Mesh internal pockets are better than solid ones because airflow helps damp gear dry.
A gym bag that doubles as a travel bag needs a packing system or it becomes a chaos bag instantly. The Eagle Creek Pack-It cubes are what I use — they are specifically designed for compression and organization within a duffel, the mesh windows make it easy to find things, and they keep gym clothes separated from travel clothes when you are using both on the same trip.

Gym showers require a kit that hangs, seals, and dries fast. The Bagsmart toiletry bag does all three — hook for gym shower hooks, waterproof lining, and a layout that makes the contents findable without unpacking everything. This is the kit that goes in the wet compartment of the gym bag.

Most gym locker locks are combination locks that reset when you forget the combination. The Master Lock TSA combination lock is not specifically a gym lock but it is the right size, has a reliable mechanism, and costs $10 — which is approximately what you want to spend on a gym locker lock.

Bags with more than four external pockets. They snag on things, create confusion about where anything lives, and make the bag look tactical rather than versatile.
Canvas bags for gym use. Canvas absorbs sweat and odors and does not dry well. Fine for weekend travel only; bad for gym-plus-travel use.
Anything over 45L for both uses. It will not fit in a gym locker and is borderline as a personal item or carry-on. The 30 to 40L range is the sweet spot.
30L: gym bag + one-night trip with light packing. Right for most people. 40L: gym bag + two-night trip comfortably. Good for people who pack a bit more or need a second pair of shoes. Under 25L: gym only — not enough for a real overnight unless you pack extremely light.
Most commercial gym lockers are 12 inches wide, 18 inches tall, and 18 to 24 inches deep. A 30 to 35L duffel in a cylindrical shape fits this reliably. Backpack-style gym bags often fit better than duffels because you can stand them upright. Anything wider than 14 inches will be tight in some lockers.
No bag is smell-proof, but antimicrobial lined bags (often labeled with Microban or similar treatments) hold up better. More importantly: air out any bag fully between uses, never leave wet gear sealed inside overnight, and wash the bag occasionally. The smell comes from bacteria growth, and the solution is removing the damp environment they need.
A 40L soft-sided duffel usually qualifies as a carry-on on most major airlines. Budget carriers (Spirit, Frontier) have stricter dimensions — check before traveling. The advantage of a duffel over a rigid suitcase is that soft-sided bags compress slightly to fit in tight overhead bins.
The Herschel Novel Duffel reads as put-together rather than athletic, has a dedicated shoe compartment, and comes in a color range that works in professional settings. It is the crossover bag for people whose weekend trips are sometimes business-adjacent.
Packing cubes. One cube for clean travel clothes, one mesh laundry bag for used gym clothes. The mesh bag doubles as a ventilated container that slows the smell problem. This is the system — it is not complicated, it just requires committing to it from the first pack.